We discussed the danger of lacking regeneration calls, best regen practices and some performance issues quite a while ago, and an example of problems resulting from accessing stale data in the location curve of a newly inserted family instance.
Here is another interesting and very clear little example of one of the many problems that you can run into if you forget to regenerate appropriately, raised and resolved by Armand Marshall of EIC Engineers, Inc.:
Question: I've been working on reading values from an Excel file and creating text in Revit from that. I read the discussion on TextNote rotation and notice that you read the TextNote.Width value. When I create a TextNote myself and try to set the TextNote.Width, it doesn't seem to work:
Document activeDoc = commandData.Application .ActiveUIDocument.Document; View currentView = activeDoc.ActiveView; XYZ origin = new XYZ( 0, 0, 0 ); XYZ baseVec = new XYZ( 0, 0, 0 ); XYZ upVec = new XYZ( 0, 0, 1 ); double lineWid = 0.125; string strText = string1; TextNote textNote = activeDoc.Create.NewTextNote( currentView, origin, baseVec, upVec, lineWid, TextAlignFlags.TEF_ALIGN_CENTER | TextAlignFlags.TEF_ALIGN_MIDDLE, strText ); textNote.Width = 21.2;
Setting the width seems to have no effect. I am trying to set the width wide enough to avoid the text wrapping.
If I display the value in a task dialog, i.e. TaskDialog.Show("Test", textNote.Width.ToString()), it comes up and says that the width is zero.
Any idea what might be going on?
Answer: Your code looks ok to me, and I am not aware of any issues with text notes and width at all. I am sure others are using this as well, so I cannot imagine what the problem might be.
The API documentation says: With this method, the width of the TextNote object can be retrieved and changed. The set method will calculate the real width of the TextNote. If the requested width is less than the real width, the real width will be set instead of the requested width.
Have you tried using different alignment flags? Different widths?
Response: I figured out the problem!
After you create the TextNote, it is as if it doesn't exist until there is a regeneration.
So I added a call to activeDoc.Regenerate after creating it and before setting its width, and now it works fine.
Answer: Yes, this is always a likely culprit, and I should definitely make a habit of always asking people what their regeneration option and transaction mode are before thinking of anything else.
Many thanks to Armand for this helpful example!